Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include binarybuilds from dependencies. #52

Merged
merged 3 commits into from
Jul 8, 2018
Merged

Include binarybuilds from dependencies. #52

merged 3 commits into from
Jul 8, 2018

Conversation

evetion
Copy link
Member

@evetion evetion commented Jul 7, 2018

This is the recommended work-around approach untill JuliaPackaging/BinaryBuilder.jl#194 is done.
See also https://github.com/JuliaIO/ImageMagick.jl/tree/sd/binaryprovider/deps

Depencies are build.jl files from their latest releases.

@evetion
Copy link
Member Author

evetion commented Jul 7, 2018

Quote from @staticfloat on Slack regarding JuliaPackaging/BinaryBuilder.jl#194:

There are hacky ways to fix this right now, but we’re going to rework how dependencies interact with Pkg3 this summer to make these kinds of workarounds easier. For now, I suggest just putting build.jl files for each of your independent pieces (libjpeg, libpng, etc…) into your deps/ directory, then running them in order.

@visr
Copy link
Member

visr commented Jul 7, 2018

Ah ok, good to know. So then I guess we have to make sure that these build files don't clash with the ones in the other packages if we want to be able to use them together right?

@evetion
Copy link
Member Author

evetion commented Jul 7, 2018

We could put back the packages (LibGEOS, Proj4, CodecZlib) in REQUIRE, in this way you guarantee that there won't be version differences if one of those package is loaded first or vice versa.

However, as before, clashes can still occur due to other packages or system libraries.

@staticfloat
Copy link

staticfloat commented Jul 7, 2018 via email

evetion and others added 2 commits July 8, 2018 12:14
For zlib this does not use the modified build.jl in the CodecZlib repo, but the original bicycle1885/ZlibBuilder version.
We don't support the other platforms yet anyway.

If we run into issues like JuliaIO/CodecZlib.jl#21, perhaps we should use an older build.
@visr visr merged commit b23f7e3 into master Jul 8, 2018
@visr visr deleted the use-deps branch July 8, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants